-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate a service.instance.id resource attribute if it is not present #2113
Comments
I like the idea of generating 1 if no |
AI for me is to investigate what other SIGs are doing and when this was added to the spec. At SIG, we decided that option 2. would need some spec discussion in SIG so we will skip it for now. |
There's some spec discussion here open-telemetry/opentelemetry-specification#1034. One of the things they mentioned is similar to option 2. Let's see if we can get some clarity in the spec. |
@aabmass, has there been any new update on this? |
Spec discussion open-telemetry/opentelemetry-specification#3136 |
There has been some updates in the spec regarding this issue since last post in the thread.
Such an identifier would be a lifesaver for automated differentiation of metric streams from services with a fork-process model. |
From the spec
At the moment, just using the default resource in our SDK violates the requirement that "
service.namespace,service.name,service.instance.id
triplet MUST be globally unique":This is very important for metrics where resource is part of the identity of a time series and we must not violate the single-writer principle.
service.instance.id
from a UUID if it is not present? I think yes, so that we do not violate the global uniqueness.container.id
when present (this might be a spec question).service.*
attributes into the SDK if they don't want it generated? E.g. an environment variable, constructor kwarg to the Tracer/Meter provider, kwarg to the resource.The text was updated successfully, but these errors were encountered: