Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add Jeff to the contribution list #584

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aspects19
Copy link

Description

Added my name to the contribution hence kickstastarting my contribution to this project.

What type of PR is this? (check all applicable)

  • [x ] 🤝 Add a contributor
  • 📝 Documentation Update

Related Issues

issue: closes #583

Contributors Checklist

I've read through the Getting Started section

  • [x ] ✅ Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • [x ] ✅ Yes
  • ❌ No

Added to documentation?

  • 📜 README.md
  • [x
    Screenshot from 2024-11-26 20-09-43
    ] 🙅 no documentation needed

Screenshot (Required for PR Review)

[optional] What GIF best describes this PR or how it makes you feel?

@aspects19 aspects19 requested a review from a team as a code owner November 26, 2024 17:10
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "Feat", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aspects19,

Thank you for your contribution! ✨

You have a failed check that you need to address before we can review your PR. Please fix it until the check passes.

Let us know once you've fixed it, or if you have questions or need help.

Thank you. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add @aspects19 as a contributor.
2 participants