Update to Bevy 0.13 #232
Update to Bevy 0.13 #232
Conversation
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
There was a problem hiding this comment.
It is sadly a pickle. Ran into this issue while testing. Closing the camera preview window creates a panic in winit that seems to have been fixed with 0.14.
However, 0.14 migration is still stuck on #231 (comment).
Will let this sit for a while, if 0.14 doesn't get unstuck I would propose temporarily commenting out the Preview button to remove the possible panic
| - {pose: {trans: [1973, 633, 2.6]}, kind: {type: point, color: [0.5, 0.5, 1.0, 1.0]}} | ||
| - {pose: {trans: [1973, 633, 2.6]}, kind: {type: point, color: [0.5, 0.5, 1.0]}} |
There was a problem hiding this comment.
Lights in the bevy renderer itself don't use the alpha channel (and it's unclear what alpha even means for a light color), hence changed them to be RGB
| bevy_mod_outline = "0.7" | ||
| bevy_infinite_grid = "0.12" | ||
| bevy_gltf_export = { git = "https://github.com/luca-della-vedova/bevy_gltf_export", branch = "bevy_0.13"} | ||
| bevy_polyline = { git = "https://github.com/luca-della-vedova/bevy_polyline", branch = "luca/bevy_0.13_panic" } |
There was a problem hiding this comment.
bevy_polyline in 0.13 panics, this is fixed in their 0.14 release but was not backported, once we update we won't need a custom branch anymore.
| Circle { | ||
| OffsetCircle { |
There was a problem hiding this comment.
Circle cannot be used anymore since it was added to the prelude as part of the primitive shape support effort.
I renamed this OffsetCircle since it's a circle with a Z offset but any other solution is also OK.
| exposure: Exposure { | ||
| ev100: Exposure::EV100_INDOOR, | ||
| }, |
There was a problem hiding this comment.
As part of the work on lighting and cameras, a new component was added for exposure. I'm defaulting it to indoor exposure and changing the light default accordingly.
| Query<((), With<LiftDoormat>)>, | ||
| Query<(), With<LiftDoormat>>, |
There was a problem hiding this comment.
This is very interesting, the query was actually wrong (it was querying for a tuple of empty component and a With<> component, while it should have queried for the entity component with a With<> condition).
In 0.13 they made it a syntax error, so this was great
| let mut ambient_light = world.get_resource_mut::<AmbientLight>().expect( | ||
| "Make sure bevy's PbrPlugin is initialized before the cameras"); | ||
|
|
||
| ambient_light.brightness = 2.0; |
There was a problem hiding this comment.
Since we made everything a lot darker than default bevy, I also had to reduce the ambient light otherwise its effect would be overwhelming the rendering and everything would look washed out.
rmf_site_editor/Cargo.toml
Outdated
| # Disable the manage_clipboard feature, depends on nightly web features | ||
| bevy_egui = { version = "0.27", features = ["open_url", "default_fonts", "render"] } |
There was a problem hiding this comment.
Ref vladbat00/bevy_egui#270, manage_clipboard only works on nightly web APIs
Signed-off-by: Luca Della Vedova <[email protected]>
|
Second block on web, bevyengine/bevy#11278 is only available in 0.14 and the 0.13 behavior regressed with the workaround not really working, will just wait for 0.14 now. |
Signed-off-by: Luca Della Vedova <[email protected]>
luca-della-vedova
force-pushed
the
luca/bevy_0.13
branch
from
8cd47fe
to
70f4329
Compare
Signed-off-by: Luca Della Vedova <[email protected]>
luca-della-vedova
force-pushed
the
luca/bevy_0.13
branch
from
70f4329
to
910c8e6
Compare
New feature implementation
Implemented feature
As per description. We technically can go up to 0.14 but it is currently stuck on #231 (comment), so this gets us closer (the 0.13 -> 0.14 breakage is minimal, so not a lot of duplicated work).
Implementation description
Will comment on the lines themselves for migrations that were not trivial