Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Split for json_serde::Value #35

Open
wants to merge 1 commit into
base: koonpeng/service-registry
Choose a base branch
from

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented Nov 27, 2024

This PR implements the new split operation for serde_json::Value. I also cleaned up two more things while working on that:

  • Give explicit lifetimes to Chain::split operations so the FnOnce build functions could output something that utilizes those lifetimes
  • Refactor SplitAsMap::next so that anything using MapSplitKey can take advantage of the premade next for it.

@mxgrey mxgrey requested a review from koonpeng November 27, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

1 participant