Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More comprehensive tests for trimming #6

Open
1 task done
mxgrey opened this issue Jul 28, 2024 · 0 comments
Open
1 task done

More comprehensive tests for trimming #6

mxgrey opened this issue Jul 28, 2024 · 0 comments

Comments

@mxgrey
Copy link
Contributor

mxgrey commented Jul 28, 2024

Before proceeding, is there an existing issue or discussion for this?

Description

We support an operation for "trimming" a workflow, meaning cancelling any activity going on within a specified span of the workflow. We have a rudimentary test for this operation, but it would be good to have more comprehensive tests, especially tests that ensure the span calculation is working correctly.

Tests to validate the span calculations could be done with unit tests inside of operate_trim.rs that manually build pseudo-workflow topologies by spawning entities with the right components, rather than spawning an entire proper workflow.

@mxgrey mxgrey added this to PMC Board Jul 28, 2024
@github-project-automation github-project-automation bot moved this to Inbox in PMC Board Jul 28, 2024
@mxgrey mxgrey moved this from Inbox to Todo in PMC Board Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant