From ab60b8f44c4ef1500bdd9b45f97f5ff660766ebd Mon Sep 17 00:00:00 2001 From: "LeoJhon.Song" Date: Sat, 5 Oct 2024 22:43:33 +0800 Subject: [PATCH 1/5] remove never used param skip_list --- mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py b/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py index dc0065d5b9..8f0d6c4a57 100644 --- a/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py +++ b/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py @@ -36,8 +36,6 @@ class SimpleMPJPE(BaseMetric): names to disambiguate homonymous metrics of different evaluators. If prefix is not provided in the argument, ``self.default_prefix`` will be used instead. Default: ``None``. - skip_list (list, optional): The list of subject and action combinations - to be skipped. Default: []. """ ALIGNMENT = {'mpjpe': 'none', 'p-mpjpe': 'procrustes', 'n-mpjpe': 'scale'} @@ -45,8 +43,7 @@ class SimpleMPJPE(BaseMetric): def __init__(self, mode: str = 'mpjpe', collect_device: str = 'cpu', - prefix: Optional[str] = None, - skip_list: List[str] = []) -> None: + prefix: Optional[str] = None) -> None: super().__init__(collect_device=collect_device, prefix=prefix) allowed_modes = self.ALIGNMENT.keys() if mode not in allowed_modes: @@ -54,7 +51,6 @@ def __init__(self, f"'n-mpjpe', but got '{mode}'.") self.mode = mode - self.skip_list = skip_list def process(self, data_batch: Sequence[dict], data_samples: Sequence[dict]) -> None: From 053fafb7770bcc4c225532913e7c297ce327da75 Mon Sep 17 00:00:00 2001 From: "LeoJhon.Song" Date: Sat, 5 Oct 2024 23:26:44 +0800 Subject: [PATCH 2/5] remove unused `List` --- mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py b/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py index 8f0d6c4a57..1588e4b185 100644 --- a/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py +++ b/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py @@ -1,5 +1,5 @@ # Copyright (c) OpenMMLab. All rights reserved. -from typing import Dict, List, Optional, Sequence +from typing import Dict, Optional, Sequence import numpy as np from mmengine.evaluator import BaseMetric From a6c9123b07afae7e250d327467a075151e51323d Mon Sep 17 00:00:00 2001 From: "LeoJhon.Song" Date: Sun, 6 Oct 2024 00:18:25 +0800 Subject: [PATCH 3/5] fix doc string for mode --- mmpose/evaluation/metrics/keypoint_3d_metrics.py | 6 +++--- mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/mmpose/evaluation/metrics/keypoint_3d_metrics.py b/mmpose/evaluation/metrics/keypoint_3d_metrics.py index fb3447bb3f..b39bf69643 100644 --- a/mmpose/evaluation/metrics/keypoint_3d_metrics.py +++ b/mmpose/evaluation/metrics/keypoint_3d_metrics.py @@ -27,9 +27,9 @@ class MPJPE(BaseMetric): ground truth. Supported options are: - ``'mpjpe'``: no alignment will be applied - - ``'p-mpjpe'``: align in the least-square sense in scale - - ``'n-mpjpe'``: align in the least-square sense in - scale, rotation, and translation. + - ``'p-mpjpe'``: align in the least-square sense in scale, + rotation, and translation. + - ``'n-mpjpe'``: align in the least-square sense in scale. collect_device (str): Device name used for collecting results from different ranks during distributed training. Must be ``'cpu'`` or diff --git a/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py b/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py index 1588e4b185..5099f15214 100644 --- a/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py +++ b/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py @@ -25,9 +25,9 @@ class SimpleMPJPE(BaseMetric): ground truth. Supported options are: - ``'mpjpe'``: no alignment will be applied - - ``'p-mpjpe'``: align in the least-square sense in scale - - ``'n-mpjpe'``: align in the least-square sense in - scale, rotation, and translation. + - ``'p-mpjpe'``: align in the least-square sense in scale, + rotation, and translation. + - ``'n-mpjpe'``: align in the least-square sense in scale. collect_device (str): Device name used for collecting results from different ranks during distributed training. Must be ``'cpu'`` or From 42d0cde4552cf856e44fe90eae9659b080000329 Mon Sep 17 00:00:00 2001 From: "LeoJhon.Song" Date: Sun, 6 Oct 2024 00:44:00 +0800 Subject: [PATCH 4/5] fix doc string --- mmpose/evaluation/metrics/keypoint_3d_metrics.py | 2 +- mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mmpose/evaluation/metrics/keypoint_3d_metrics.py b/mmpose/evaluation/metrics/keypoint_3d_metrics.py index b39bf69643..da2109f337 100644 --- a/mmpose/evaluation/metrics/keypoint_3d_metrics.py +++ b/mmpose/evaluation/metrics/keypoint_3d_metrics.py @@ -20,7 +20,7 @@ class MPJPE(BaseMetric): Note: - length of dataset: N - num_keypoints: K - - number of keypoint dimensions: D (typically D = 2) + - number of keypoint dimensions: D (typically D = 3) Args: mode (str): Method to align the prediction with the diff --git a/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py b/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py index 5099f15214..38307e5632 100644 --- a/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py +++ b/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py @@ -18,7 +18,7 @@ class SimpleMPJPE(BaseMetric): Note: - length of dataset: N - num_keypoints: K - - number of keypoint dimensions: D (typically D = 2) + - number of keypoint dimensions: D (typically D = 3) Args: mode (str): Method to align the prediction with the From fb0e52b3e7966351d22fe68e6f771a9fa7305369 Mon Sep 17 00:00:00 2001 From: "LeoJhon.Song" Date: Sun, 6 Oct 2024 10:33:29 +0800 Subject: [PATCH 5/5] fix docstring --- mmpose/evaluation/metrics/keypoint_3d_metrics.py | 2 +- mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mmpose/evaluation/metrics/keypoint_3d_metrics.py b/mmpose/evaluation/metrics/keypoint_3d_metrics.py index da2109f337..4314472db0 100644 --- a/mmpose/evaluation/metrics/keypoint_3d_metrics.py +++ b/mmpose/evaluation/metrics/keypoint_3d_metrics.py @@ -79,7 +79,7 @@ def process(self, data_batch: Sequence[dict], gt = data_sample['gt_instances'] # ground truth keypoints coordinates, [T, K, D] gt_coords = gt['lifting_target'] - # ground truth keypoints_visible, [T, K, 1] + # ground truth keypoints_visible, [T, K] mask = gt['lifting_target_visible'].astype(bool).reshape( gt_coords.shape[0], -1) # instance action diff --git a/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py b/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py index 38307e5632..87d3dc55c4 100644 --- a/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py +++ b/mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py @@ -73,7 +73,7 @@ def process(self, data_batch: Sequence[dict], gt = data_sample['gt_instances'] # ground truth keypoints coordinates, [T, K, D] gt_coords = gt['lifting_target'] - # ground truth keypoints_visible, [T, K, 1] + # ground truth keypoints_visible, [T, K] mask = gt['lifting_target_visible'].astype(bool).reshape( gt_coords.shape[0], -1)