fix(api/#163): Part 1: Add an API to get pending operator information #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryphe
added a commit
to onivim/oni2
that referenced
this pull request
Aug 26, 2020
Some prep work to address #2357 - this plumbs through some additional context for modes, so that we can display it in the status bar and elsewhere. This updates the `Mode` variant to be able to handle contextual state (and updates all the downstream dependencies). With this change - we'll be able to integrate it with onivim/libvim#218 so we can add some operator pending info for #2357
bryphe
added a commit
to onivim/oni2
that referenced
this pull request
Aug 26, 2020
__Issue:__ As described in #2357 , we weren't showing any context around a pending operator in the status bar - this is really a step backward. __Fix:__ This picks up onivim/libvim#218 so that we get some context around the current pending operator, and we show it in now in the statusbar:  This fixes the operator-pending part of #2357 - we're missing showing the in-progress count of a command, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an API to get the current pending-operator information (what operator is pending, any associated register, and count). This is part of a fix for #163 - there are still some items that would be useful that this doesn't provide (ie, typed characters prior to an operator becoming active).