-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disregard mkrf_conf.rb as a requirement for DevKit #268
base: master
Are you sure you want to change the base?
Conversation
It has become a common trick to use an extension configure script named `mkrf_conf.rb` to install conditional dependencies via Gem::DependencyInstaller when installing a gem. cf. http://en.wikibooks.org/wiki/Ruby_Programming/RubyGems#How_to_install_different_versions_of_gems_depending_on_which_version_of_ruby_the_installee_is_using A `mkrf_conf.rb` script is expected to generate a `Rakefile` which is later run by rake(1), and that doesn't necessarily require build tools like make(1), C compiler, etc.
This is the best solution I've seen yet to this problem. That being said I'm still a little skeptical of using anything that is in I do think it's a problem though. See #259. Umm, I'm going to ping @drbrain and @luislavena to see what they think. |
Why not load the devkit and ignore mkrf extensions at the |
@drbrain @knu That's actually really good compromise. I would totally accept/merge that. Thank you for looking at it. 😄 @drbrain I do have a quick question about |
It's a clever workaround and is officially unsupported. |
Actually, installing gems via extensions does not work well with bundler (esp. under |
@knu Alright, well if you find a solution that you like then I'll be glad to help you getting it running on RubyInstaller. |
What I'm suggesting here is omit the check for devkit when extensions only contain |
@knu Sorry, I meant in addition to this change. For this if could just change the location of the check so that we can fail to load the DevKit THEN check to see if it's just a |
As Devkit will be done away with in next release, shall we close this? |
RubyInstaller2 does not seem to have this problem, so I'm happy with it. Is there any new release from this repo? |
It has become a common trick to use an extension configure script named
mkrf_conf.rb
to conditionally install extra dependencies via Gem::DependencyInstaller when installing a gem.cf. http://en.wikibooks.org/wiki/Ruby_Programming/RubyGems#How_to_install_different_versions_of_gems_depending_on_which_version_of_ruby_the_installee_is_using
A
mkrf_conf.rb
script is expected to generate aRakefile
which is later run by a standard tool rake(1), and that doesn't necessarily require build tools like make(1), C compiler, etc.With this change, a gem could even make a dependency on a native gem optional using a
mkrf_conf.rb
so users on Windows without DevKit could run it.