Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http instead of https being used for download links. #346

Closed
picatz opened this issue Nov 26, 2016 · 11 comments
Closed

Http instead of https being used for download links. #346

picatz opened this issue Nov 26, 2016 · 11 comments

Comments

@picatz
Copy link

picatz commented Nov 26, 2016

How I insecurely installed ruby and why and things:

At the following url : ruby-lang.org/en/documentation/installation/#rubyinstaller there is a link to the ruby installer website. Note: unlike the link I have made for this issue, the ruby-lang.org website has the following link which is an "insecure" version of the ruby installer website because it's not bering served with https. This http version also seems to be the version I am directed to from the google index of "downloads" from what I can tell:
googley

The following is a screenshot of what I'm talking about:
screen shot 1

When you click on this link, you're taken to an insecure version of the ruby installer website. Note the lack of the green lock:
screen shot 2

So, if I were to want to install ruby ( which I did ), I would be doing so via an insecure connection opening myself up to attacks. Moreover, the actual ruby installer website is serving their default download links with http as well ( from what I can tell ):
screen shot 3

I've yet to do any testing to see how vulnerable this current setup is. But, knowing what I know about what should and shouldn't be served over https -- well, I just think these situations warrant it.

When I update or install packages with brew -- that seems to be done over https. I can configure apt to use https. Python's download page seems have all of its download links with https.

Perhaps I could just add a little s to the link from the downloads page to make it https?
http://dl.bintray.com/oneclick/rubyinstaller/rubyinstaller-2.3.1.exe
I haven't tried. Just tried.
https://dl.bintray.com/oneclick/rubyinstaller/rubyinstaller-2.3.1.exe
Seems to have worked just to the same.

I think it should be the default link to install if the option is there for an extra layer of security by default.

@picatz
Copy link
Author

picatz commented Nov 26, 2016

Note: this could totally have been an issue opened in the wrong place.

But, ya' know, you only live once, right?

@picatz
Copy link
Author

picatz commented Nov 26, 2016

Moved to probably the right place for this.

@picatz picatz closed this as completed Nov 26, 2016
@picatz
Copy link
Author

picatz commented Nov 26, 2016

UNLESS THIS IS THE RIGHT ONE? WHAT IS THIS PLACE?

@picatz picatz reopened this Nov 26, 2016
@vais
Copy link

vais commented Nov 27, 2016

@picatz I am as confused as you are at this point... https://github.com/oneclick/rubyinstaller.org does not seem to match what's on the rubyinstaller.org website, so I'm not sure how to make a PR for the website to fix this issue. bintray.com seems to support https just fine, so it's only a matter of updating the links to use https instead of http, but where's the website source? cc @Azolo

@vais
Copy link

vais commented Nov 27, 2016

@picatz btw I made a PR to update the link to rubyinstaller.org on the ruby-lang site, ruby/www.ruby-lang.org#1514 Thanks!

@picatz
Copy link
Author

picatz commented Nov 27, 2016

Awesome!

@luislavena
Copy link
Member

All the download links in rubyinstaller.org are now https.

@picatz
Copy link
Author

picatz commented Dec 1, 2016

Thanks!

@vais
Copy link

vais commented Dec 1, 2016

@luislavena sorry to bother you, is the source of rubyinstaller.org not on GitHub? The repo that is on GitHub does not seem to match the site 😕

@luislavena
Copy link
Member

@vais see conversation on this thread: #309 (comment) (starts at that comment with explanation of repos and current setup).

@vais
Copy link

vais commented Dec 1, 2016

Awesome, thank you @luislavena. And for what it's worth, we miss you and appreciate all you have done and continue to do despite having officially stepped away from the project quite a while ago. Again, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants