New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Drawing CJK characters #165

Open

myevan opened this issue Aug 25, 2019 · 2 comments

Labels

bug

Contributor

myevan commented Aug 25, 2019

rot.js has a bug when drawing CJK characters in node (ok in web)

First bug is rot.js does not support CJK unicode blocks

https://en.wikipedia.org/wiki/Unicode_block

0x1100 ~ 0x11FF (Korean: optional)

0x2E80 ~ 0x9FFF (CJK)

0xA960 ~ 0xA97F (Korean: optional)

0xAC00 ~ 0xD7FF (Korean)

CJK characters are full-width characters, but they are strangely printed in node.
In english, it's like this: Hello -> Hello or H e l l o (안녕 -> 안녕 or 안 녕 )

node english (ok)

node korean (bug)

node japanese (bug)

rot.js needs special work to draw CJK characters correctly and I tried to fix the bug.

myevan/js-ecs@8bf688b

node korean (fixed)

node japanese (fixed)

web korean (no problem)

thanks.

The text was updated successfully, but these errors were encountered:

Owner

ondras commented Aug 26, 2019

thanks for the report! It would be great if you managed to send a PR, provided you were already able to fix the issue.

ondras added the bug label

Contributor Author

myevan commented Aug 27, 2019

hi @ondras,
thank you for your answer. i'm a beginner in javascripting and will need some time for making the PR : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment