Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prov/rxm: add FI_PEER support to rxm #10510

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

prov/rxm: add FI_PEER support to rxm #10510

wants to merge 4 commits into from
+693 −1,213

Commits on Nov 26, 2024

  1. prov/rxm: fix definition of the rxm SAR segment enum 

    The rxm SAR segment type enum was defined inside another struct.
While techincally ok, this made it difficult for editors to find
the type and reported compiler errors. This cleans it up to make
it more readible and easier for editors to find the type

Signed-off-by: Alexia Ingerson <[email protected]>
    @aingerson
    aingerson committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    943d6b0 View commit details
    Browse the repository at this point in the history

  2. prov/rxm: add FI_AV_USER_ID support 

    Add application side support for FI_AV_USER_ID which requires
saving the fi_addr input as the internal fi_addr (for both the
peer API srx use case and for reporting unique source address
information).
When supporting the capability for the application, remove it
form the core provider information as it is only required on the
top layer

Signed-off-by: Alexia Ingerson <[email protected]>
    @aingerson
    aingerson committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    cdd047a View commit details
    Browse the repository at this point in the history

  3. prov/rxm: add rxm support for using a peer CQs and counters 

    Support using the peer APIs by default using the util peer helper
functions. Instead of going through the rxm-specific functions to write
to CQs and counters, use the ofi_peer_cq/cntr APIs which use the
owner ops. In the default case where rxm is not being used as a peer
these will go to the regular ofi_cq_write functions.

Signed-off-by: Alexia Ingerson <[email protected]>
    @aingerson
    aingerson committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    2293f5d View commit details
    Browse the repository at this point in the history

  4. prov/rxm: replace rxm managed srx with util srx, support FI_PEER 

    Remove rxm implementation of receive queues and leverage the util
srx implementation which supports the peer srx API. This allows rxm
to use the peer API calls to match receives.

To do this, move the rxm protocol information from the receive entry
into the rx_buf and allocate it dynamically as needed to track protocol
information. This allows rxm to use the default peer_rx_entry instead of
its own custom receive entry.

With this last piece of the peer API implemented, rxm can also now
advertise full support of the FI_PEER capability. Just like the
FI_AV_USER_ID capability, rxm removes the bit from the core provider
info as it is only a requirement from the application side and not
from the message provider

Signed-off-by: Alexia Ingerson <[email protected]>
    @aingerson
    aingerson committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    e47be50 View commit details
    Browse the repository at this point in the history