Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prov/lpp: Address coverity scan issues #10438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tstruk
Copy link
Contributor

@tstruk tstruk commented Oct 7, 2024

Address coverity scan issues in LPP and lpp_regression fabtest.

Address coverity scan issues in LPP and lpp_regression fabtest.

Signed-off-by: Tadeusz Struk <[email protected]>
@@ -233,7 +234,7 @@ static void *info_server_thread(void *arg)

int info_server_sock = setup_server(info_server_port);

while (1) {
while (server_running) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sever_running is set to 1 before the thread is created and never set to 0. What's the difference from the old code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to stop the coverity complaining about dead code after the while loop.

@a-szegel
Copy link
Contributor

bot:aws:retest

1 similar comment
@j-xiong
Copy link
Contributor

j-xiong commented Oct 15, 2024

bot:aws:retest

@a-szegel
Copy link
Contributor

AWS CI failed to compile with:


ERROR    root:utils.py:94 Command make -j failed with error:

prov/lpp/src/main.c:140:32: error: initializer element is not constant

 static const int total_tests = ((num_tests + num_cuda_tests + num_rocm_tests));

                                ^

make[1]: *** [prov/lpp/src/main.o] Error 1

make[1]: *** Waiting for unfinished jobs....

prov/lpp/src/test_util.c: In function ‘util_init’:

prov/lpp/src/test_util.c:135:13: warning: 'FI_MR_BASIC' is deprecated

  hints.domain_attr->mr_mode = FI_MR_BASIC;

             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

make: *** [all] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants