Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write missing tests #1108

Open
p-snft opened this issue Aug 19, 2024 · 0 comments
Open

Write missing tests #1108

p-snft opened this issue Aug 19, 2024 · 0 comments

Comments

@p-snft
Copy link
Member

p-snft commented Aug 19, 2024

Nonetheless, I'd like to raise two points. I don't see them as critical, but rather want to raise awareness:

  1. It seems to me that not yet all of the constraints are tested one by one as they actually should. I didn't find an explicit test for bus balance constraints or the converter efficiencies for instance. These were at least implicity contained in the tests before, because at least I also checked these when comparing the LP files.
  2. Some experimental components did have testing before, but now they don't have it anymore.

Originally posted by @jokochems in #1080 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant