Increase solver timeout #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punchagan
approved these changes
Sep 19, 2024
Trying to fix ocurrent#354. Recreates ocurrent#342 (for which the branch has been deleted). If this timeout is long enough, it will address the timeouts on opam 2.0, 2.1, and 2.2, since this env var has been supported at least since 2.0: https://github.com/ocaml/opam/blob/7d4a0f2e0fefe748efbd7358775b1a0bd8267544/src/solver/opamSolverConfig.ml#L131-L132 This can increase the build time of some tests, but I think it should be worth it if it can give proper results: - Only few builds (~3) per PR run on these older opam versions. - We are wasting a lot of cumulative preson time having to check the CI - results for PR that should be green if the CI wasn't giving these (arguably) false negatives.
punchagan
force-pushed
the
354/increase-timeout
branch
from
a8e836e to
d7460ce
Compare
mtelvers
approved these changes
Sep 19, 2024
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #354.
Recreates #342 (for which the branch has been deleted).
If this timeout is long enough, it will address the timeouts on opam
2.0, 2.1, and 2.2, since this env var has been supported at least since 2.0:
https://github.com/ocaml/opam/blob/7d4a0f2e0fefe748efbd7358775b1a0bd8267544/src/solver/opamSolverConfig.ml#L131-L132
This can increase the build time of some tests, but I think it should be
worth it if it can give proper results:
results for PRs that should be green if the CI wasn't giving these
(arguably) false negatives.