Feat: [#1109] - extended compliance finding - compliance by adding co… #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelJurka
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka and
zschmerber
as code owners
…g compliance_references and _standards based on kb_article to provide possibility to map KB articles with information relevant to finding.
PavelJurka
force-pushed
the
1109-compliance-extension
branch
from
50477c9 to
4660399
Compare
Signed-off-by: Pavel Jurka <[email protected]>
davemcatcisco
approved these changes
Jun 26, 2024
davemcatcisco
approved these changes
Jun 28, 2024
irakledibm
approved these changes
Jun 28, 2024
floydtree
requested changes
Jun 28, 2024
pagbabian-splunk
approved these changes
Jul 2, 2024
floydtree
approved these changes
Jul 2, 2024
Aniak5
reviewed
Jul 2, 2024
| @@ -58,6 +58,8 @@ Thankyou! --> | |||
| 7. Added `whois` object. #992 | |||
| 8. Added `domain_contact` and array-typed `domain_contacts` object for use with `whois` object. #992 | |||
| 9. Added `Windows Service` object to the Windows extension. #1103 | |||
| 10. Added array-typed `compliacne_references` and array-typed `compliance_standards` objects as array of `kb_article` and used in `compliance` object. #1110 | |||
There was a problem hiding this comment.
This is misspelled and should be compliance_references.
floydtree
added a commit
that referenced
this pull request
Oct 29, 2024
#### Related Issue: n/a #### Description of changes: 1. Creating a generic key:value object. Thank you @Aniak5 for the suggestion. 2. Creating instances of that generic object - `control_parameters` & `tags`. Removing the specific tag object definition. 3. Adding `control_parameters` to `compliance` object. 4. Deprecating `status_detail` in the compliance object, in favor of `status_details`, a new string array attribute 5. Adding new item in `status_id` enum for findings classes, to allow representation of finding archival. 6. Updating descriptions & captions. * Attempting to distinguish between existing and extra attributes that were added to compliance in #1110 --------- Signed-off-by: Rajas Panat <[email protected]> Signed-off-by: Rajas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1109
The extension is:
compliance finding . compliance with:
compliance_references: Array of KB Article
compliance_standards: Array of KB Article