Make implicit functors ordinary module types #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow definitions like:
implicit module Foo {X : S} = struct ... end
to be separated into
module Foo {X : S} = struct ... end
implicit F = Foo
by treating `functor {X : S} -> T` as a proper module type distinguished
from `functor (X : S) -> T`.
lpw25
added a commit
that referenced
this pull request
Nov 7, 2015
Make implicit functors ordinary module types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow definitions like:
to be separated into
by treating
functor {X : S} -> Tas a proper module type distinguishedfrom
functor (X : S) -> T. This also forcesFoo(Bar)to now be writtenFoo{Bar}.This should make #28 and #35 easier, as well as paving the way to one day support implicit module parameters.
By representing the three possible kinds of functor argument (generative, applicative and implicit) properly using a variant type the patch also flushes out a number of small bugs around generative functors.