Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with focus on clickable image #1357

Closed
Goodiec opened this issue Apr 1, 2021 · 5 comments · Fixed by #1496
Closed

Issue with focus on clickable image #1357

Goodiec opened this issue Apr 1, 2021 · 5 comments · Fixed by #1496

Comments

@Goodiec
Copy link
Contributor

Goodiec commented Apr 1, 2021

Noticed an issue in the Books column on the learn page. Clicking on the first image applies the style for focus on the second image. Clicking on the second image applies to the second and also the outline from the style displays off the outline of the images. This issue is shown in the images below:

issue2
issue2 1

This can cause users to be confused and actually doubt if they clicked on the right image and doesn't give the best user experience. If this issue is approved, I can go ahead to try to fix this.

@gs0510
Copy link

gs0510 commented Apr 1, 2021

This is a really good catch @Goodiec ! You can go ahead and fix this. Thank you!

@pitag-ha
Copy link
Member

pitag-ha commented Apr 9, 2021

How is it going @Goodiec? :) Are you still working on this?

@Goodiec
Copy link
Contributor Author

Goodiec commented Apr 9, 2021

How is it going @Goodiec? :) Are you still working on this?

Yes @pitag-ha, will open a pull request for it shortly. Thank you

@Goodiec
Copy link
Contributor Author

Goodiec commented Apr 9, 2021

@pitag-ha, @gs0510, I am trying to see if I can come up with layout improvements/new layout suggestions for some of the website pages especially those with a lot of content, is that within the scope of the contribution period? Also, I would be glad if you could point me to medium and more challenging issues relating to the project I am interested in working on (Improving the Ocam,org website), thank you

@gs0510
Copy link

gs0510 commented Apr 9, 2021

@Goodiec I tagged you on this medium issue: #1321 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants