Skip to content

Commit

Permalink
Bump minimal OCaml version.
Browse files Browse the repository at this point in the history
  • Loading branch information
@toots
toots committed Mar 2, 2023
1 parent d986f65 commit 3d1a133
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dune-project
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Unicode. Unlike ocamllex, sedlex allows lexer specifications within regular
OCaml source files. Lexing specific constructs are provided via a ppx syntax
extension.")
(depends
(ocaml (>= 4.08))
(ocaml (>= 4.14))
dune
(ppxlib (>= 0.26.0))
gen
Expand Down
2 changes: 1 addition & 1 deletion sedlex.opam
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ license: "MIT"
homepage: "https://github.com/ocaml-community/sedlex"
bug-reports: "https://github.com/ocaml-community/sedlex/issues"
depends: [
"ocaml" {>= "4.08"}
"ocaml" {>= "4.14"}
"dune" {>= "2.8"}
"ppxlib" {>= "0.26.0"}
"gen"
Expand Down

3 comments on commit 3d1a133

@hhugo
Copy link
Contributor

@hhugo hhugo commented on 3d1a133 Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toots, What's the motivation for such move ? Could we try to keep compatibility with 4.08 ?

@toots
Copy link
Member Author

@toots toots commented on 3d1a133 Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember the specific but my recollection is that this was an acknowledgement of something already in the code that required 4.14.0, probably noticed in ocaml/opam-repository#23442

@hhugo
Copy link
Contributor

@hhugo hhugo commented on 3d1a133 Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened #132

Please sign in to comment.