Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatString.split_on_string since 2.11? #1122

Open
jmid opened this issue Oct 26, 2023 · 3 comments
Open

BatString.split_on_string since 2.11? #1122

jmid opened this issue Oct 26, 2023 · 3 comments

Comments

@jmid
Copy link

jmid commented Oct 26, 2023

The documentation for BatString.split_on_string says @since 2.11.0
https://github.com/ocaml-batteries-team/batteries-included/blob/master/src/batString.mli#L798

However I couldn't find any mention of it in https://github.com/ocaml-batteries-team/batteries-included/blob/v2.11.0/src/batString.mliv and on the CI run for this opam-repo PR ocaml complained about it with
# Error: Unbound value BatString.split_on_string
https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/2cf1ce6a52fb08f0fadcc6cbf13ad64f6ce4d684/variant/compilers,4.09,lbvs_consent.2.1.2,lower-bounds

I suspect, the documentation should just say @since 3.0.0 instead.

@UnixJunkie
Copy link
Member

Can you check in the changelog file since which release it is mentioned?

@jmid
Copy link
Author

jmid commented Oct 27, 2023

There are only two mentions of split_on_string in the changelog - and both are bugfixes (in 3.7.1 and in 3.6.0).

@UnixJunkie
Copy link
Member

UnixJunkie commented Oct 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants