Make the SSSOM/T ruleset future-proof. #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is one particular bit of syntax that is currently used in the
SSSOM/T ruleset that I would like to disallow in the upcoming version of
SSSOM/Java. Specifically, the dereferencing of a variable enclosed in
angled brackets, as in:
"... and (<%TAXREL> some NCBITaxon:????)"
It should either be "%TAXREL" (no angled brackets, preferred form as it
is more readable) or "<%{TAXREL}>" (angled brackets + variable name
enclosed in curly brackets).
The first form is already allowed with current versions of SSSOM-Java,
so we can switch to it immediately without breaking anything.
gouttegd
added
tech
bridge-files
matentzn
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one particular bit of syntax that is currently used in the SSSOM/T ruleset that I would like to disallow in the upcoming version of SSSOM/Java. Specifically, the dereferencing of a variable enclosed in angled brackets, as in:
It should either be
%TAXREL(no angled brackets, preferred form as it is more readable) or<%{TAXREL}>(angled brackets + variable name enclosed in curly brackets — cumbersome, but more consistent throughout SSSOM/T).The first form is already allowed with current versions of SSSOM-Java, so we can switch to it immediately without breaking anything. And this will ensure nothing will also break when the upcoming SSSOM-Java will land in the ODK.