Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility with ZFA's "head". #3360

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Conversation

gouttegd
Copy link
Collaborator

In ZFA, the "head" (ZFA:0001114) corresponds to what Uberon calls the "craniocervical region" (UBERON:0007811), comprising the head proper and the neck. So we remap ZFA:0001114 to UBERON:0007811, rather than UBERON:0000033).

Also, the axiom stating that 'pharyngeal arch' (UBERON:0002539) is part of the 'embryonic head' (UBERON:0008816) is bogus, as some pharyngeal arches are located in the neck rather than the head. So we create a new term 'embryonic craniocervical region' to be the embryonic counterpart of 'craniocervical region' (as 'embryonic head' is the embryonic counterpart of 'head'), and rewrite the aforementioned axiom to state that 'pharyngeal arch' is part of the 'embryonic craniocervical region'.

Combined together, these two changes fix about 80 unsatisfiable classes in the merge product of Uberon and ZFA.

closes #379

In ZFA, the "head" (ZFA:0001114) corresponds to what Uberon calls the
"craniocervical region" (UBERON:0007811), comprising the head proper and
the neck. So we remap ZFA:0001114 to UBERON:0007811, rather than
UBERON:0000033).

Also, the axiom stating that 'pharyngeal arch' (UBERON:0002539) is part
of the 'embryonic head' (UBERON:0008816) is bogus, as some pharyngeal
arches are located in the neck rather than the head. So we create a new
term 'embryonic craniocervical region' to be the embryonic counterpart
of 'craniocervical region' (as 'embryonic head' is the embryonic
counterpart of 'head'), and rewrite the aforementioned axiom to state
that 'pharyngeal arch' is part of the 'embryonic craniocervical region'.

Combined together, these two changes fix about 80 unsatisfiable classes
in the merge product of Uberon and ZFA.

closes #379
@gouttegd gouttegd self-assigned this Sep 12, 2024
Not really useful for a definition that is merely the English
translation of the logical definition, but it keeps the CI checks happy.
@gouttegd gouttegd requested a review from cmungall September 12, 2024 15:49
@aleixpuigb
Copy link
Collaborator

#gogoeditdiff

Copy link

Here's a diff of how these changes impact the classified ontology (on -base file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2024-10-24/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-main.owl/uberon-base.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2024-10-24/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-pr.owl/uberon-base.owl

Ontology imports

Ontology annotations

1st arch mesenchyme from head mesenchyme http://purl.obolibrary.org/obo/UBERON_0010341

Removed

2nd arch mesenchyme from head mesenchyme http://purl.obolibrary.org/obo/UBERON_0010343

Removed

3rd arch mesenchyme from head mesenchyme http://purl.obolibrary.org/obo/UBERON_0010344

Removed

4th arch mesenchyme from head mesenchyme http://purl.obolibrary.org/obo/UBERON_0010345

Removed

6th arch mesenchyme from head mesenchyme http://purl.obolibrary.org/obo/UBERON_0010347

Removed

afferent filamental artery http://purl.obolibrary.org/obo/UBERON_2005012

Removed

afferent lamellar arteriole http://purl.obolibrary.org/obo/UBERON_2005015

Removed

afferent portion of pharyngeal arch artery http://purl.obolibrary.org/obo/UBERON_2000716

Removed

concurrent branch afferent branchial artery http://purl.obolibrary.org/obo/UBERON_2005013

Removed

craniocervical region http://purl.obolibrary.org/obo/UBERON_0007811

Added

efferent filamental artery http://purl.obolibrary.org/obo/UBERON_2005018

Removed

efferent lamellar arteriole http://purl.obolibrary.org/obo/UBERON_2005019

Removed

efferent portion of pharyngeal arch artery http://purl.obolibrary.org/obo/UBERON_2000202

Removed

embryonic craniocervical region http://purl.obolibrary.org/obo/UBERON_8450003

Added

head http://purl.obolibrary.org/obo/UBERON_0000033

Removed

pharyngeal arch http://purl.obolibrary.org/obo/UBERON_0002539

Removed

Added

pharyngeal arch artery http://purl.obolibrary.org/obo/UBERON_0004363

Removed

pharyngeal arch mesenchymal region http://purl.obolibrary.org/obo/UBERON_0009494

Removed

Added

recurrent branch afferent branchial artery http://purl.obolibrary.org/obo/UBERON_2005014

Removed

Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/branch/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

craniocervical region http://purl.obolibrary.org/obo/UBERON_0007811

Added

embryonic craniocervical region http://purl.obolibrary.org/obo/UBERON_8450003

Added

head http://purl.obolibrary.org/obo/UBERON_0000033

Removed

pharyngeal arch http://purl.obolibrary.org/obo/UBERON_0002539

Removed

Added

@aleixpuigb
Copy link
Collaborator

I am wondering if it would be benefitial to add a GCI ('part of' some embryo) and ('part of' some 'craniocervical region') SubClassOf 'part of' some 'embryonic craniocervical region'. Otherwise I will approve this PR.

@gouttegd
Copy link
Collaborator Author

I am wondering if it would be benefitial to add a GCI ('part of' some embryo) and ('part of' some 'craniocervical region') SubClassOf 'part of' some 'embryonic craniocervical region'.

Sounds sensible, but unsure about how beneficial it would be.

Unfortunately the effects of adding such a GCI wouldn’t be shown by gogoeditdiff, because we’d need robot materialize (instead of just robot reason) to infer 'part of' some 'embryonic craniocervical region' parents, and we cannot use robot materialize in GitHub actions because it’s too memory-intensive with Uberon.

@aleixpuigb
Copy link
Collaborator

yes, I used DL queries in Protégé and compared the results.

Add the following GCI axiom

  ('part of' some embryo) and ('part of' some 'craniocervical region')
    SubClassOf: 'part of' some 'embryonic craniocervical region'
@gouttegd gouttegd merged commit 074809e into master Oct 25, 2024
1 check passed
@gouttegd gouttegd deleted the 379-fix-mapping-zfa-head branch October 25, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is a head?
2 participants