-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bronchus should be part of lung as well as part of tracheobronchial tree #3410
Labels
Comments
dosumis
added a commit
to obophenotype/cell-ontology
that referenced
this issue
Nov 7, 2024
Fixed by aligning both textual and logical defs Fixes #432 Note - classification of "bronchus ciliated cell" under lung will be fixed by obophenotype/uberon#3410
The definition should be updated, the main bronchus is part inside and part outside the lung. We could add |
Yes the definition shoukd be updated )IMO it doesn’t say it’s part of the
lung it’s just vague )
Asserting overlaps is often an anti-pattern (and most users don’t use
anyway). It’s usually better to have more comprehensive has parts
(carefully as this is where a lot of taxon variance comes in) and infer the
overlaps
…On Thu, Nov 7, 2024 at 5:03 AM Aleix Puig ***@***.***> wrote:
The definition should be updated, the main bronchus is part inside and
part outside the lung. We could add ovelaps some lung.
—
Reply to this email directly, view it on GitHub
<#3410 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGZRCAMTBHVIQMVADFFCGDZ7NQLXAVCNFSM6AAAAABRLBJ5EKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRSGE4DOOBWGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
aleixpuigb
added a commit
that referenced
this issue
Nov 13, 2024
Fixes #3410 has_part bronchus to lung
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uberon term
rdfs:label "bronchus"
id "UBERON:0002185"
definition "The upper conducting airways of the lung; these airways arise from the terminus of the trachea."
Suggested revision of logical definition
add
SubClassOf part_of some lung
The text was updated successfully, but these errors were encountered: