Skip to content

Commit

Permalink
Make the SSSOM/T ruleset future-proof.
Browse files Browse the repository at this point in the history
There is one particular bit of syntax that is currently used in the
SSSOM/T ruleset that I would like to disallow in the upcoming version of
SSSOM/Java. Specifically, the dereferencing of a variable enclosed in
angled brackets, as in:

  "... and (<%TAXREL> some NCBITaxon:????)"

It should either be "%TAXREL" (no angled brackets, preferred form as it
is more readable) or "<%{TAXREL}>" (angled brackets + variable name
enclosed in curly brackets).

The first form is already allowed with current versions of SSSOM-Java,
so we can switch to it immediately without breaking anything.
  • Loading branch information
gouttegd committed Nov 29, 2024
1 parent 8385067 commit 99ecf28
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/scripts/sssomt.m4
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ifelse($2, , `dnl
predicate==skos:exactMatch -> create_axiom("%subject_id EquivalentTo: %object_id");
predicate==skos:broadMatch -> create_axiom("%subject_id SubClassOf: %object_id");
predicate==skos:narrowMatch -> create_axiom("%object_id SubClassOf: %subject_id");',`dnl
predicate==semapv:crossSpeciesExactMatch -> create_axiom("%subject_id EquivalentTo: %object_id and (<%TAXREL> some $2)");')')
predicate==semapv:crossSpeciesExactMatch -> create_axiom("%subject_id EquivalentTo: %object_id and (%TAXREL some $2)");')')

dnl Expand to instructions to create all possible bridging axioms
dnl both for Uberon and for CL
Expand Down

0 comments on commit 99ecf28

Please sign in to comment.