Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test provider.getSigner is wrapped with sapphire-ethers-v6 in MetaMask #324

Open
CedarMist opened this issue Jun 27, 2024 · 0 comments
Open

Test provider.getSigner is wrapped with sapphire-ethers-v6 in MetaMask #324

CedarMist opened this issue Jun 27, 2024 · 0 comments
Labels
javascript Pull requests that update JavaScript code

Comments

@CedarMist
Copy link
Member

Using the getSigner method of a wrapped provider, need to verify that the signer will encrypt transactions, view calls and gas estimates.

e.g.

const p = wrapEthereumProvider(window.ethereum);
const s = p.getSigner();
// TODO: test tx submission, view calls & gas estimates are encrypted
@CedarMist CedarMist added js javascript Pull requests that update JavaScript code labels Jun 27, 2024
@aefhm aefhm removed the js label Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
javascript Pull requests that update JavaScript code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aefhm @CedarMist