Events: NWNX_ON_SET_EXPERIENCE update to allow SetEventResult #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikgit
force-pushed
the
xp-event-update
branch
from
77d7d75
to
ba30729
Compare
hendrikgit
changed the title
Daztek
reviewed
Oct 13, 2024
Comment on lines
+221
to
+224
| else if (const auto newXP = String::FromString<uint32_t>(result)) | ||
| { | ||
| s_SetExperienceHook->CallOriginal<void>(thisPtr, newXP.value(), bDoLevel); | ||
| } |
There was a problem hiding this comment.
What happens if you skip the event without setting a result?
There was a problem hiding this comment.
Only checking from the phone now so I hope I'm not overlooking anything but my intention was that then nothing happens. No CallOriginal. Skipping the event (without setting a result) means no xp change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to set event result. Now the event can be (better) used to limit xp.