Creature: Add SetMulticlassLimit #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikgit
force-pushed
the
multiclass-limit
branch
from
8f7d6c2
to
a17c316
Compare
Daztek
reviewed
Oct 10, 2024
Plugins/Creature/Creature.cpp
Outdated
|
|
||
| NWNX_EXPORT ArgumentStack SetMulticlassLimit(ArgumentStack&& args) | ||
| { | ||
| if (!s_bGetIsClassAvailableHookInitialized) |
There was a problem hiding this comment.
No need to check/set a static bool, the static hook below will only be initialized once
Plugins/Creature/Creature.cpp
Outdated
| static Hooks::Hook s_GetClassLevelHook = nullptr; | ||
|
|
||
| static std::unordered_map<uint8_t, std::unordered_map<ObjectID, int16_t>> s_RollModifier; | ||
| static std::unordered_map<ObjectID, bool> s_ParryAllAttacks; | ||
| static std::unordered_map<OBJECT_ID, uint> s_MulticlassLimits; |
There was a problem hiding this comment.
Why an unordered_map instead of using NWNX's POS? With POS you can have it persist to the bic too
hendrikgit
force-pushed
the
multiclass-limit
branch
from
a17c316
to
352447d
Compare
|
Thanks Daz. I removed the static bool and switched to using POS. |
|
Maybe add a |
hendrikgit
force-pushed
the
multiclass-limit
branch
from
352447d
to
94913fe
Compare
|
Added a get function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
NWNX_Creature_SetMulticlassLimit(object oCreature, int nLimit)to limit the number of classes a PC can take dynamically.