Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks: add NWNX_TWEAKS_CAN_USE_ITEMS_WHILE_POLYMORPHED #1780

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

hendrikgit
Copy link
Contributor

I'm not sure about the Hooks::Order

@Daztek
Copy link
Member

Daztek commented Oct 13, 2024

Hooks::Order::Early should be ok.

Here's what I usually follow, but it can be fuzzy

The rule for ordering should be roughly:
Earliest for pure event notification hooks
Early for skippable events, or events that modify state in before/after
Late for things that provide alternative implementation in some cases, like the POS getters in creature
Latest for things that almost never call the original
Final for things that fully reimplement base game functions

@hendrikgit
Copy link
Contributor Author

Changed to Hooks::Order::Early.

@Daztek Daztek merged commit c176945 into nwnxee:master Oct 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants