Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2113-F12-2] EquipmentManager #21

Open
wants to merge 352 commits into
base: master
Choose a base branch
from

Conversation

shunyao643
Copy link

EquipmentManager is a Command Line Interface application to help with keeping track of equipment details (e.g. current user, quantity, cost, warranty duration, purchase date) for the AV club. It provides a clean and fast way to manage the inventory as compared to “traditional” methods such as an excel spreadsheet.

yuhaochua and others added 30 commits March 22, 2022 14:39
* 'master' of https://github.com/AY2122S2-CS2113-F12-2/tp:
  Fix remaining pending Java CI errors
  Update all classes for Java CI checks
  Shift tests for prepareModification to ModificationCommandTest from UpdateCommandTest
  Update code based on comments given by @shunyao643 for pull request 57
  Update creatioin of Parser object to be outside of do while loop
  Update welcome message to tell users to enter help if they need help.
  Update Javadocs for HelpCommand.execute()
  Add HelpCommand to show available commands to users.
  Add UI class to have UI displaying messages to users.
  Add JUnit test for new method checkAttributes() in AddCommand
  Rename DuplicateSerialNumber to DuplicateSerialNumberException
  Update AddCommand to support any order of strings given to add new equipment
  Add logic to check for successful update in UpdateCommand
  Add exception
  Add Storage class
Fix Java CI errors arising from test files
Additionally, improved documentation for splitCommandTerm
@yuhaochua, please check if this is the expected behaviour from your end!
Rationale: extractArguments can handle all instances of prepareAdd
parser and acknowledgements
Support parsing of capitalised commands, enumeration and argument tags
* 'master' of https://github.com/AY2122S2-CS2113-F12-2/tp:
  Add documentation for architecture, parser and acknowledgements
  Return type enumeration in all caps
  Deprecate prepareAdd entirely
  Replace magic constants in Parser's prepareView and prepareDelete with named elements
  Include regex101.com debug link for easy maintainence
  Reformat Regex for improved readability
  Add helper method to set argument tags to lowercase
  Switch prepareAdd to extractArguments for Parser
  Add support for parsing command word regardless of case
  Implement full equals method for IncorrectCommand for JUnit test
Test case written as well with ListCommand equals implementation
shunyao643 and others added 30 commits April 10, 2022 02:16
Exception Handling in Parser
Developer Guide: Update Product Scope, User Stories, Non-Functional Requirements
…into branchDocumentations

* 'master' of https://github.com/AY2122S2-CS2113-F12-2/tp: (23 commits)
  Update enhancements implemented
  Update shunyao643.md
  Complete JavaDoc for Parser.java
  Fix uncaught exceptions in Parser
  Catch DateTimeParseException for Update command
  Touchup rest of DeveloperGuide.md
  Update User Stories table
  Update Parser regex documentation
  Add Parser terminology to glossary
  Reformat Instructions for manual testing
  Standardise formatting for Developer Guide
  Add Storage in DG and change file name
  Add some user stories
  Minor edit to Value Proposition
  Remove deprecated test case for parseCommand
  Remove deprecated code
  Refactor constants in Parser.java
  Elaborate on DeveloperGuide.md's Design and Implementation
  Elaborate on DeveloperGuide.md's Design and Implementation
  Refactor Parser#splitCommandTerm with updated JavaDoc
  ...
Add more informative error for $ parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants