-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2113-F12-2] EquipmentManager #21
Open
shunyao643
wants to merge
352
commits into
nus-cs2113-AY2122S2:master
Choose a base branch
from
AY2122S2-CS2113-F12-2:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CS2113-F12-2] EquipmentManager #21
shunyao643
wants to merge
352
commits into
nus-cs2113-AY2122S2:master
from
AY2122S2-CS2113-F12-2:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch implement UI class
Branch unordered tags
* 'master' of https://github.com/AY2122S2-CS2113-F12-2/tp: Fix remaining pending Java CI errors Update all classes for Java CI checks Shift tests for prepareModification to ModificationCommandTest from UpdateCommandTest Update code based on comments given by @shunyao643 for pull request 57 Update creatioin of Parser object to be outside of do while loop Update welcome message to tell users to enter help if they need help. Update Javadocs for HelpCommand.execute() Add HelpCommand to show available commands to users. Add UI class to have UI displaying messages to users. Add JUnit test for new method checkAttributes() in AddCommand Rename DuplicateSerialNumber to DuplicateSerialNumberException Update AddCommand to support any order of strings given to add new equipment Add logic to check for successful update in UpdateCommand Add exception Add Storage class
Fix Java CI errors arising from test files
Additionally, improved documentation for splitCommandTerm
@yuhaochua, please check if this is the expected behaviour from your end!
Work in progress
Rationale: extractArguments can handle all instances of prepareAdd
parser and acknowledgements
Support parsing of capitalised commands, enumeration and argument tags
Developer Guide
* 'master' of https://github.com/AY2122S2-CS2113-F12-2/tp: Add documentation for architecture, parser and acknowledgements Return type enumeration in all caps Deprecate prepareAdd entirely Replace magic constants in Parser's prepareView and prepareDelete with named elements Include regex101.com debug link for easy maintainence Reformat Regex for improved readability Add helper method to set argument tags to lowercase Switch prepareAdd to extractArguments for Parser Add support for parsing command word regardless of case Implement full equals method for IncorrectCommand for JUnit test
Test case written as well with ListCommand equals implementation
Exception Handling in Parser
Update shunyao643.md
Developer Guide: Update Product Scope, User Stories, Non-Functional Requirements
…into branchDocumentations * 'master' of https://github.com/AY2122S2-CS2113-F12-2/tp: (23 commits) Update enhancements implemented Update shunyao643.md Complete JavaDoc for Parser.java Fix uncaught exceptions in Parser Catch DateTimeParseException for Update command Touchup rest of DeveloperGuide.md Update User Stories table Update Parser regex documentation Add Parser terminology to glossary Reformat Instructions for manual testing Standardise formatting for Developer Guide Add Storage in DG and change file name Add some user stories Minor edit to Value Proposition Remove deprecated test case for parseCommand Remove deprecated code Refactor constants in Parser.java Elaborate on DeveloperGuide.md's Design and Implementation Elaborate on DeveloperGuide.md's Design and Implementation Refactor Parser#splitCommandTerm with updated JavaDoc ...
…into documentationTweaks
Documentation tweaks
Update sequence diagrams
Finalise remaining code
Add more informative error for $ parsing
Change file name to bryan-bc.md
Add README in tp/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EquipmentManager is a Command Line Interface application to help with keeping track of equipment details (e.g. current user, quantity, cost, warranty duration, purchase date) for the AV club. It provides a clean and fast way to manage the inventory as compared to “traditional” methods such as an excel spreadsheet.