Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Score difference in zxcvbn4j and zxcvbn-ts #178

Open
parashartarun opened this issue Jul 12, 2024 · 1 comment
Open

Score difference in zxcvbn4j and zxcvbn-ts #178

parashartarun opened this issue Jul 12, 2024 · 1 comment

Comments

@parashartarun
Copy link

parashartarun commented Jul 12, 2024

We already have zxcvbn-ts on our UX layer, now we are implementing it in backend and tried to use zxcvbn4j /nbvcxz java libraries . Now problem is we are getting different score from UI and backend. Please help in understanding:

  • Is there any other java equivalent of zxcvbn-ts
  • How can we bring parity.
  • Any other suggestions

CC : @vvatanabe @HaasJona

@HaasJona
Copy link
Contributor

zxcvbn-ts seems to be a loose reimplementation of the original zxcvbn with some customizations. And nbvcxz is the same, if not worse. I don't know how accurate zxcvbn4j copies the original library, but it's probably the most precise reimplementation of these.

In any case, achieving identical rating between these doesn't seem feasible to me, or it would be a lot of work at least. I'm sure you can do it, but it would probably be a better idea to do something else, e.g. compile zxcvbn4j to javascript (maybe using the Kotlin compiler) or somehow call typescript code from the java backend (multiple ways to do that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants