Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quasi- Node.js net.Server, consumeable Websockify #10

Open
rektide opened this issue Oct 2, 2014 · 1 comment
Open

quasi- Node.js net.Server, consumeable Websockify #10

rektide opened this issue Oct 2, 2014 · 1 comment

Comments

@rektide
Copy link

rektide commented Oct 2, 2014

Websockify is a fine websocket<->TCP proxy.

I'd like to also see this node.js port be useable within a Node.js process natively, without having to connect to the TCP port exposed by Websockify. Instead of creating a node.js process that listens for TCP, then having a separate websockify process that connects to it, Websockify could export a Node.js net.Server like object that emits connection events with something that works more or less like a net.Socket. By making Websockify embeddable inside Node programs, we skip having to make the in-between TCP connnection and host TCP services directly behind Websockify.

@kanaka
Copy link
Member

kanaka commented Oct 3, 2014

That sounds like a great refactor. The python code is already split somewhat like that (websocket.py and websocketproxy.py).

I look forward to a pull request :-)

@samhed samhed transferred this issue from novnc/websockify Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants