Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web streams: commit pull-into descriptors after filling from queue #56072

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MattiasBuelens
Copy link
Contributor

Implements whatwg/streams#1326

Fixes #56044

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (4efb7ae) to head (b49a05e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56072      +/-   ##
==========================================
+ Coverage   87.99%   88.01%   +0.01%     
==========================================
  Files         656      656              
  Lines      188988   189016      +28     
  Branches    35988    35999      +11     
==========================================
+ Hits       166302   166354      +52     
+ Misses      15848    15835      -13     
+ Partials     6838     6827      -11     
Files with missing lines Coverage Δ
lib/internal/webstreams/readablestream.js 98.44% <100.00%> (+0.12%) ⬆️
lib/internal/webstreams/util.js 94.64% <100.00%> (+0.20%) ⬆️

... and 23 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. web streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Streams: commit pull-into descriptors after filling from queue
2 participants