Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config for leaving URL fragment unchanged #20

Open
fortm opened this issue Aug 11, 2016 · 2 comments
Open

config for leaving URL fragment unchanged #20

fortm opened this issue Aug 11, 2016 · 2 comments

Comments

@fortm
Copy link

fortm commented Aug 11, 2016

If base URL is as below -
http://localhost/project/module#fragment_key=fragment_value

the plugin adds # to end of URL when click event occurs on mainButtonClass="mfb-component__button--main" and URL becomes as below -
http://localhost/project/module#

So the fragment_key and fragment_value is removed. I am opening a modal on click for menu item and would ideally have the URL unchanged so that when modal closes the fragment in URL don't change as the page has not changed

Is this possible that clicking on menu button / menu item does not lead to displacement of exisiting URL fragment in favour of "#" ?

@fortm
Copy link
Author

fortm commented Aug 11, 2016

<a> tag without href helps for menu button

 <a  class="mfb-component__button--main">
                  <i class="mfb-component__main-icon--resting ion-navicon-round"></i>
                  <i class="mfb-component__main-icon--active ion-navicon-round"></i>
</a>

@shivkanthb
Copy link

Have href="javascript:;" and it wont add the '#' to the end of the url!

<a href="javascript:;" class="mfb-component__button--main main-btn">
          <i class="mfb-component__main-icon--resting ion-plus-round"></i>
          <i class="mfb-component__main-icon--active ion-close-round"></i>
</a>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants