Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ GPU ] Enable x86 OpenCL with some fixes #2776

Open
EunjuYang opened this issue Oct 29, 2024 · 3 comments
Open

[ GPU ] Enable x86 OpenCL with some fixes #2776

EunjuYang opened this issue Oct 29, 2024 · 3 comments
Assignees

Comments

@EunjuYang
Copy link
Contributor

/home/donghak/Desktop/workspace/nntrainer/nntrainer/opencl/opencl_program.cpp:73:10: error: variable length array ‘binaries_size’ is used [-Werror=vla]
   73 |   size_t binaries_size[num_devices];
      |          ^~~~~~~~~~~~~
/home/donghak/Desktop/workspace/nntrainer/nntrainer/opencl/opencl_program.cpp:98:8: error: variable length array ‘kernel_names’ is used [-Werror=vla]
   98 |   char kernel_names[kernel_names_size];
      |        ^~~~~~~~~~~~
/home/donghak/Desktop/workspace/nntrainer/nntrainer/opencl/opencl_program.cpp:113:18: error: variable length array ‘binaries_ptr’ is used [-Werror=vla]
  113 |   unsigned char *binaries_ptr[num_devices];

as mesntioned in #2770.

  • In order to fully enable OpenCL for x86 environment, some compilation error should be handled.
@taos-ci
Copy link

taos-ci commented Oct 29, 2024

:octocat: cibot: Thank you for posting issue #2776. The person in charge will reply soon.

@EunjuYang
Copy link
Contributor Author

#2727 is resolving this issue. It can be fixed after the PR is merged.

@EunjuYang
Copy link
Contributor Author

Upon the resolving PR, it still has some build error for x86 without enable-fp16=true option. It needs to be fixed.

@EunjuYang EunjuYang self-assigned this Oct 30, 2024
EunjuYang added a commit to EunjuYang/nntrainer that referenced this issue Oct 30, 2024
- This commit resolves nnstreamer#2776
- This commit separate FP16-related functions from _cl.cpp file.
- Minor bug is fixed

Signed-off-by: Eunju Yang <[email protected]>
EunjuYang added a commit to EunjuYang/nntrainer that referenced this issue Nov 4, 2024
- This commit resolves nnstreamer#2776
- This commit separate FP16-related functions from _cl.cpp file.
- Minor bug is fixed

Signed-off-by: Eunju Yang <[email protected]>
EunjuYang added a commit to EunjuYang/nntrainer that referenced this issue Nov 4, 2024
- This commit resolves nnstreamer#2776
- This commit separate FP16-related functions from _cl.cpp file.
- Minor bug is fixed

Signed-off-by: Eunju Yang <[email protected]>
EunjuYang added a commit to EunjuYang/nntrainer that referenced this issue Nov 4, 2024
- This commit resolves nnstreamer#2776
- This commit separate FP16-related functions from _cl.cpp file.
- Minor bug is fixed

Signed-off-by: Eunju Yang <[email protected]>
EunjuYang added a commit to EunjuYang/nntrainer that referenced this issue Nov 4, 2024
- This commit resolves nnstreamer#2776
- This commit separate FP16-related functions from _cl.cpp file.
- Minor bug is fixed

Signed-off-by: Eunju Yang <[email protected]>
EunjuYang added a commit to EunjuYang/nntrainer that referenced this issue Nov 4, 2024
- This commit resolves nnstreamer#2776
- This commit separate FP16-related functions from _cl.cpp file.
- Minor bug is fixed

Signed-off-by: Eunju Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants