[ GPU ] split kernel registration from forwarding function in addition_layer_cl and transpose_cl
#2810
+38
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EunjuYang
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8 and
djeong20
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2810. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
taos-ci
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
@EunjuYang, 💯 All CI checkers are successfully verified. Thanks.
- This commit updates addition_layer_cl.cpp/h to inherit LayerImplCl. - This commit implements registerClKernels() of addition_layer_cl layer. - This commit update cl_context.cpp (applying addition_layer_cl's update) Self evaluation: Build test: [X]Passed [ ]Failed [ ]Skipped Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Eunju Yang <[email protected]>
- This commit updates transpose_cl.cpp/h to inherit LayerImplCl. - This commit implements registerClKernels() of transpose_cl layer. - This commit update cl_context.cpp (applying transpose_cl's update) - This is the last commit to complete nnstreamer#2723. - This can close nnstreamer#2723. Self evaluation: Build test: [X]Passed [ ]Failed [ ]Skipped Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Eunju Yang <[email protected]>
EunjuYang
force-pushed
the
gpu_layer_refactor_add_transpose
branch
from
d325aee
to
64f3d0d
Compare
EunjuYang
changed the title
addition_layer_cl and transpose_claddition_layer_cl and transpose_cl
taos-ci
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
@EunjuYang, 💯 All CI checkers are successfully verified. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ GPU/OpenCL ] change
addition_layer_clandtranspose_clto inherit LayerImplCladdition_layer_clandtranspose_cl.cpp/h to inherit LayerImplCl.addition_layer_clandtranspose_cllayer.addition_layer_clandtranspose_cl's update)Self evaluation:
Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped