Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when pinging a user through command the ping is sanitized out #22

Open
isaacmorneau opened this issue Jul 4, 2018 · 3 comments
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@isaacmorneau
Copy link
Contributor

using insult or echo will not actually ping the user though the @user is still in place. this is likely due to the usage of the clean message doing sanitization we weren't aware of

@isaacmorneau isaacmorneau added bug Something isn't working enhancement New feature or request labels Jul 4, 2018
@JulianWebb JulianWebb self-assigned this Jul 7, 2018
@JulianWebb
Copy link
Contributor

The issue I worry about in regards to changing the line from const arg = message.cleanContent.split(' ') to const arg = message.content.split(' ') is how it might affect the JS commands within events/message.js

@isaacmorneau
Copy link
Contributor Author

we could also maybe get it by checking the mentioned users that are returned with the message and adding them in after

@JulianWebb
Copy link
Contributor

I've done some tests with having the arguments for the plugins be made separately from the rest. It's a quick fix but I want to get this branch merged before the big DB update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants