Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex ICA with GIFT #5

Open
tsalo opened this issue Aug 25, 2024 · 7 comments
Open

Complex ICA with GIFT #5

tsalo opened this issue Aug 25, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@tsalo
Copy link
Collaborator

tsalo commented Aug 25, 2024

What would you like to see added in this software?

Would be cool to include complex ICA with GIFT. GIFT is a MATLAB toolbox, so this might be tough to include in a container.

Do you have any interest in helping implement the feature?

Yes

Additional information / screenshots

We might be able to base the Docker image on https://github.com/trendscenter/gift-bids and/or https://hub.docker.com/r/trends/gift-bids. Or maybe https://hub.docker.com/r/trendscenter/gift?

Relevant issue: trendscenter/gift#25

@tsalo
Copy link
Collaborator Author

tsalo commented Aug 27, 2024

@tsalo
Copy link
Collaborator Author

tsalo commented Oct 6, 2024

Including the MATLAB runtime compiler in a Docker image apparently massively increases the size of the image (see nipreps/fmriprep#3308 (comment)), so this might not be doable.

@tsalo
Copy link
Collaborator Author

tsalo commented Oct 6, 2024

Maybe I can take https://github.com/afbujan/complex_ica and bring it up to date with sklearn's FastICA.

@tsalo
Copy link
Collaborator Author

tsalo commented Oct 9, 2024

@bpinsard do you recall exactly how much space MCR took up in your NORDIC image? I'm finding trying to translate complex-ICA to Python difficult enough that I'm tempted to just bundle GIFT into the image.

@bpinsard
Copy link

bpinsard commented Oct 9, 2024

The images I built using the matlab docker tools were about 3GB.

@tsalo
Copy link
Collaborator Author

tsalo commented Oct 9, 2024

Thanks @bpinsard! I think I might be willing to accept that kind of size for GIFT at least. I get why we want to avoid it for NORDIC in fMRIPrep though.

@bpinsard
Copy link

Maybe there are smarter ways to package the MCR https://hub.docker.com/search?q=matlabruntime show some non-official images with smaller sizes.
When I tried using matlab tools to create the docker, it seems to bundle all the extensions that the matlab license allows, in my case all the possible extensions as this is what our university license allows.
I remember also trying to find all the libraries used at run time, and prune the images from these, but this made the thing crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants