Grouping (subtotals)

[jjagielka]

Added grouping of data with minimal changes in the main code. If new options are not activated code behaves as nothing is changed. With or without new options code passes all Jasmin tests.

Changes:

• option grouping causes the insertion of group columns and rows like subtotal
• option rowGroupBefore and colGroupBefore controls whether grouping is before or after the data cells. Default to rowGroupBefore true and colGroupBefore false
• option rendererOptions.table.compactLayout turns the rows headers in to hierarchical structure. This option works only if grouping is set and defaults to true.

New example pivot() with grouping and compact layout added to examples/index.html
Also few styling entries added to pivot.css to control grouping rendering.

[nicolaskruchten]

Thanks for this PR!

A few questions:

1. How is this different from Subtotal.js?
2. Does this have any applicability other than for a table-like renderer, i.e. graphs?

[jjagielka]

ad 1. Subtotal is code of 700 lines while me is around 20 added to the main code. My version - introduces a compact layout i.e. rows are displayed in narrower space. Check the example. - works for both heatmap and barchart functions from the main code. - can have subtotals before or after the data cells - passes Jasmin tests ad 2. Gives subtotals for the graph if needed. I can return all rows/cols or only those with pure data. niedz., 24 lut 2019 o 19:52 Nicolas Kruchten <[email protected]> napisał(a):

…

Thanks for this PR! A few questions: 1. How is this different from Subtotal.js? 2. Does this have any applicability other than for a table-like renderer, i.e. graphs? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1088 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF_cDhqd5iykF7WseapazB86LcF5crqPks5vQt9agaJpZM4bOsRq> .

[nicolaskruchten]

OK, thanks for those answers. I'm hesitant to merge these changes into the main library as that means I will have to maintain them for the next few years, so I'll need to think about it a bit.

One other possibility... It looks like the changes you've made are in PivotData and the TableRenderer which is good, because both of those are injectable into PivotTable.js via parameters (dataClass and aggregator) without me merging this in, so you could do something similar to Subtotal.js and host your own repo with just those two components and the documentation for using them instead of the defaults if you like...

[nicolaskruchten]

This is basically how things started with Subtotal.js btw, after I added the dataClass parameter specifically for this use-case ;)

See: #506

[jjagielka]

Rows and columns folding.
Now you can fold/expand rows and columns in all combinations: rows (above or below) and cols (before or after) the child data.
You can as well fold/expand whole levels (subtotal can only fold levels, cannot expand them).

As for your comment about dataClass, yes that's possible to make a subclass of PivotData and override those few methods changed, but you can't do that for pivotTableRenderer.

[kuklei]

Will this ever make it into the next release?