Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication error in Adguard list #188

Open
ghost opened this issue Feb 15, 2024 · 1 comment
Open

Duplication error in Adguard list #188

ghost opened this issue Feb 15, 2024 · 1 comment
Labels

Comments

@ghost
Copy link

ghost commented Feb 15, 2024

There is many duplicate on adguard list I will take jib mobile example (at the end of the list

you have 47 rules, but 45 of them are useless in adguard rules because they are already covered by those 2

||jibe.google.com^
||jibemobile.com^

Who tell

jibe.google.com and every subdomain are blocked
jibemobile.com and every subdomain are blocked

I think it would be interesting to have a script that check if the main domain for example jibemobile.com is in the adguard list and so not add subdomain like : x.jibemobile.com because it increase the size of the list for nothing.

@ghost ghost added the other label Feb 15, 2024
@ghost ghost closed this as not planned Won't fix, can't repro, duplicate, stale Apr 15, 2024
@nickspaargaren
Copy link
Owner

You're right, let's leave this open. || is already blocking all subdomains:

https://github.com/AdguardTeam/AdGuardHome/wiki/Hosts-Blocklists#special-characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant