Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect split_range behaviour on disjointed paths #924

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

timmb
Copy link
Contributor

@timmb timmb commented Dec 4, 2024

Resolves #896

Previously split_range would create incorrect paths in the input path was formed of discontinuous subpaths because neither add_segment was not keeping track of whether we're inside a subpath or not. This PR offers the simplest way I could see to resolve.

Co-authored by @nical (for the test).

@nical
Copy link
Owner

nical commented Dec 8, 2024

Thanks a lot! Apologies for the delay, let's land this.

@nical nical merged commit ec05562 into nical:main Dec 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PathSampler::split_range seems to disregard discontinuities in the original path
2 participants