Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create git tags (and GitHub releases?) for crates.io releases #881

Open
MarijnS95 opened this issue Nov 2, 2023 · 6 comments
Open

Create git tags (and GitHub releases?) for crates.io releases #881

MarijnS95 opened this issue Nov 2, 2023 · 6 comments

Comments

@MarijnS95
Copy link

Currently it is a bit hard to figure out whether or not a commit on the master branch is included in a release, because no tags have been created after 1.0.0.

Note: in case it is useful, the original git hash that a cargo publish was issued from can be retrieved from this file in the packaged source: https://docs.rs/crate/lyon_path/1.0.4/source/.cargo_vcs_info.json.

@MarijnS95
Copy link
Author

Oh, it seems to be a bit more complicated than that because not all crates follow the same version. For example lyon_path 1.0.4 was released a few months ago, while lyon_tessellation 1.0.10 was released over 9 months ago.

In other crates where I have this setup, I prefix the tag with the crate name and create separate GitHub releases: https://github.com/rust-mobile/ndk/tags and https://github.com/rust-mobile/ndk/releases.

In particular I'd like to see #869 come to fruition in a lyon_tessellation release.

@nical
Copy link
Owner

nical commented Nov 6, 2023

I don't have a good workflow for github releases and It's not where I want to spend time and effort. It might change but in the mean time the easiest way to figure out in which version a change is is to look at the commit log and see which <crate name> <version> commit comes after the commit of interest.
I usually don't let non-api-breaking changes linger in the main branch but in this particular case I forgot to publish a new version after the dependency was bumped, sorry about that.

@nical
Copy link
Owner

nical commented Nov 6, 2023

lyon_tessellation 1.0.11 is up on crates.io

@MarijnS95
Copy link
Author

MarijnS95 commented Nov 6, 2023

I'm not asking for a full GitHub release workflow, just keeping the tags (https://github.com/nical/lyon/tags) up-to-date. This is as easy as running git tag <the version> and git push --tags after publishing a release locally.

Publishing a so-called "GitHub release" on top of that tag is a bonus at this point. The nice thing about tags is that they show up in the commit information on GitHub so that one can see at once what the first release is that includes it 🎉

If needed cargo-release can automate this for you.

@nical
Copy link
Owner

nical commented Nov 6, 2023

Thanks for the pointers. Most of my reticence is coming from ignorance (in addition to lack of time). I've put looking to that high-ish in my TODO list.

@MarijnS95
Copy link
Author

Sounds good, thanks for the release and thanks for looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants