Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create hyperlink from selected text #3260

Open
MooWeek opened this issue Jul 29, 2024 · 1 comment
Open

Create hyperlink from selected text #3260

MooWeek opened this issue Jul 29, 2024 · 1 comment
Labels
Bug

Comments

@MooWeek
Copy link

MooWeek commented Jul 29, 2024

Describe the bug

Text not chenging for hyperlink

To Reproduce

Steps to reproduce the behavior:

  1. Switch to the WYSIWYG editor mode
  2. Write the text "This is an example of a text link".
  3. Select the text "link" and click on the hyperlink
  4. Change the text to "new hyperlink" and add the url
  5. Click OK

Expected behavior

The link text should change to "new hyperlink".

Screenshots

image
image
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Mozilla Firefox
  • Version 127.0.2
@MooWeek MooWeek added the Bug label Jul 29, 2024
rawstream added a commit to rawstream/tui.editor that referenced this issue Sep 28, 2024
@rawstream
fix: create TextNode for non-empty selection when adding a link (fixes …
678e99b 
…nhn#3260)
rawstream added a commit to rawstream/tui.editor that referenced this issue Sep 28, 2024
@rawstream
fix: create TextNode when adding a link (fixes nhn#3260)
6039e71 
Also create a new TextNode when the selection is not empty.
rawstream added a commit to rawstream/tui.editor that referenced this issue Sep 28, 2024
@rawstream
fix: create TextNode when adding a link (fix nhn#3260)
45f6f37 
Also create a new TextNode when the selection is not empty.
@rawstream
Copy link

@MooWeek I openend a PR that fixes this: #3269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MooWeek @rawstream