Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new module vt/decompose_blocksub #7139

Merged
merged 10 commits into from
Dec 4, 2024
Merged

add new module vt/decompose_blocksub #7139

merged 10 commits into from
Dec 4, 2024

Conversation

kubranarci
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@kubranarci kubranarci self-assigned this Dec 2, 2024
@kubranarci kubranarci linked an issue Dec 2, 2024 that may be closed by this pull request
new module: vt/decompose_blocksub #7138
Closed
4 tasks
LouisLeNezet
LouisLeNezet requested changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tweaks but good to go for me 😉
Could I ask you to review the following in exchange ?
nf-core/test-datasets#1407

modules/nf-core/vt/decomposeblocksub/main.nf Outdated Show resolved Hide resolved
modules/nf-core/vt/decomposeblocksub/main.nf Outdated Show resolved Hide resolved
modules/nf-core/vt/decomposeblocksub/main.nf Outdated Show resolved Hide resolved
modules/nf-core/vt/decomposeblocksub/meta.yml Show resolved Hide resolved
LouisLeNezet
LouisLeNezet approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tweaks but good to go 😉

modules/nf-core/vt/decomposeblocksub/main.nf Outdated Show resolved Hide resolved
modules/nf-core/vt/decomposeblocksub/main.nf Outdated Show resolved Hide resolved
modules/nf-core/vt/decomposeblocksub/tests/main.nf.test Outdated Show resolved Hide resolved
@kubranarci kubranarci added this pull request to the merge queue Dec 4, 2024
Merged via the queue into nf-core:master with commit 30e4a82 Dec 4, 2024
30 checks passed
@kubranarci kubranarci deleted the add_new_module_vt_decompose_blocksub branch December 4, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouisLeNezet LouisLeNezet LouisLeNezet approved these changes

Assignees

@kubranarci kubranarci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: vt/decompose_blocksub
2 participants
@kubranarci @LouisLeNezet