Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clustalo as aligner to fasta_newick_epang_gappa swf #7099

Merged
merged 17 commits into from
Dec 3, 2024

Conversation

erikrikarddaniel
Copy link
Member

@erikrikarddaniel erikrikarddaniel commented Nov 26, 2024

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

This adds clustalo, in profile mode, as aligner to the subworkflow in addition to hmmalign and mafft.

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked properly, but can you not use it implicitly in the map/filter's - the new language server will warn about that.

@erikrikarddaniel
Copy link
Member Author

Haven't looked properly, but can you not use it implicitly in the map/filter's - the new language server will warn about that.

That should be done now.

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the tests could be combined into one single snapshot, rather than lots of individual ones, but that isn't essential.

@erikrikarddaniel
Copy link
Member Author

erikrikarddaniel commented Nov 27, 2024

I think that the tests could be combined into one single snapshot, rather than lots of individual ones, but that isn't essential.

That would indeed have fixed my typos -- thanks for finding them.

There are three reasons why the tests look like they do. First is maybe rather lame: I'm still learning nf-test and just don't know what I can do yet. Second, is what I think is a showstopper: Some of the outputs can't be snapshot since there are timestamps and other things in the output files (this includes the two files you found I had typos in). Third is my general preference for granular tests and thinking that individual tests make it easier to spot what broke. Maybe this is partly because of my lack of complete understanding of nf-test though.

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that's fine

@erikrikarddaniel
Copy link
Member Author

Thanks!

@erikrikarddaniel erikrikarddaniel added this pull request to the merge queue Dec 3, 2024
Merged via the queue into nf-core:master with commit 725f406 Dec 3, 2024
27 checks passed
@erikrikarddaniel erikrikarddaniel deleted the add-clustalo branch December 3, 2024 06:38
LouisLeNezet pushed a commit to LouisLeNezet/modules that referenced this pull request Dec 4, 2024
* Started to add clustalo, but the module doesn't support profile alignment yet

* Add clustalo as aligner

* Explicitly declare iterator variable

* Update subworkflows/nf-core/fasta_newick_epang_gappa/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

* Update subworkflows/nf-core/fasta_newick_epang_gappa/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

* Update subworkflows/nf-core/fasta_newick_epang_gappa/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

* Update mistakes in tests

* Remove two tests with unstable md5 sums

* Update subworkflows/nf-core/fasta_newick_epang_gappa/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

* Revert last update to test

---------

Co-authored-by: Simon Pearce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants