Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Add hadolint hook for Dockerfiles #7087

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

style: Add hadolint hook for Dockerfiles #7087

wants to merge 1 commit into from

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Nov 25, 2024 •
edited
Loading

Lints the Dockerfiles and throws some best practices https://github.com/hadolint/hadolint

Went with the Docker version instead of the binary, because hopefully if you're changing Dockerfiles, you have Docker installed.

@edmundmiller edmundmiller self-assigned this Nov 25, 2024
mirpedrol
mirpedrol approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

@mashehu mashehu mashehu approved these changes

@maxulysse maxulysse Awaiting requested review from maxulysse

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edmundmiller @mashehu @mirpedrol