-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clustalo as aligner to fasta_newick_epang_gappa swf #7099
Add clustalo as aligner to fasta_newick_epang_gappa swf #7099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked properly, but can you not use it
implicitly in the map/filter's - the new language server will warn about that.
That should be done now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the tests could be combined into one single snapshot, rather than lots of individual ones, but that isn't essential.
subworkflows/nf-core/fasta_newick_epang_gappa/tests/main.nf.test
Outdated
Show resolved
Hide resolved
subworkflows/nf-core/fasta_newick_epang_gappa/tests/main.nf.test
Outdated
Show resolved
Hide resolved
subworkflows/nf-core/fasta_newick_epang_gappa/tests/main.nf.test
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
That would indeed have fixed my typos -- thanks for finding them. There are three reasons why the tests look like they do. First is maybe rather lame: I'm still learning nf-test and just don't know what I can do yet. Second, is what I think is a showstopper: Some of the outputs can't be snapshot since there are timestamps and other things in the output files (this includes the two files you found I had typos in). Third is my general preference for granular tests and thinking that individual tests make it easier to spot what broke. Maybe this is partly because of my lack of complete understanding of nf-test though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that's fine
Thanks! |
* Started to add clustalo, but the module doesn't support profile alignment yet * Add clustalo as aligner * Explicitly declare iterator variable * Update subworkflows/nf-core/fasta_newick_epang_gappa/tests/main.nf.test Co-authored-by: Simon Pearce <[email protected]> * Update subworkflows/nf-core/fasta_newick_epang_gappa/tests/main.nf.test Co-authored-by: Simon Pearce <[email protected]> * Update subworkflows/nf-core/fasta_newick_epang_gappa/tests/main.nf.test Co-authored-by: Simon Pearce <[email protected]> * Update mistakes in tests * Remove two tests with unstable md5 sums * Update subworkflows/nf-core/fasta_newick_epang_gappa/tests/main.nf.test Co-authored-by: Simon Pearce <[email protected]> * Revert last update to test --------- Co-authored-by: Simon Pearce <[email protected]>
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda
This adds clustalo, in profile mode, as aligner to the subworkflow in addition to hmmalign and mafft.