Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL2: Add lane attribute to BAM inputs #985

Open
1 of 3 tasks
TCLamnidis opened this issue May 25, 2023 · 0 comments
Open
1 of 3 tasks

DSL2: Add lane attribute to BAM inputs #985

TCLamnidis opened this issue May 25, 2023 · 0 comments
Assignees
Labels
bug Something isn't working DSL2
Milestone

Comments

@TCLamnidis
Copy link
Collaborator

TCLamnidis commented May 25, 2023

When users provide multiple BAM files from the same library as BAM input for nf-core/eager, the only attribute that can be different between rows (other than the BAM path) is the Lane number. Therefore, the lane should be propagated into the meta map of the BAM input subchannel.

Adding this is easy enough, but the following will need to be ensured:

  • Adding this attribute does not break any downstream channel manipulations like .join, .combine etc.
  • BAMs across lanes are merged before Deduplication (as should be the case with FastQs), at which point the lane attribute will be dropped from the channel.
  • Lane info should also be in the output name for BAM filtering output (or BAM filtering occurs after merging at library level).
@TCLamnidis TCLamnidis added the bug Something isn't working label May 25, 2023
@jfy133 jfy133 self-assigned this May 26, 2023
@jfy133 jfy133 added this to the 3.0 Augsburg milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DSL2
Projects
None yet
Development

No branches or pull requests

2 participants