Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Message draft overlayed icon bug #4525

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fixed Message draft overlayed icon bug #4525

merged 1 commit into from
Dec 10, 2024

Conversation

rapterjet2004
Copy link
Contributor

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added the 3. to review Waiting for reviews label Dec 9, 2024
@rapterjet2004 rapterjet2004 requested a review from mahibi December 9, 2024 16:49
@rapterjet2004 rapterjet2004 self-assigned this Dec 9, 2024
@mahibi mahibi force-pushed the issue-4498-voice-recording-icon-overlay-bug branch from 8e902e5 to b0c828f Compare December 10, 2024 08:42
@mahibi mahibi force-pushed the issue-4498-voice-recording-icon-overlay-bug branch from b0c828f to a66d0cf Compare December 10, 2024 08:44
@rapterjet2004 @mahibi
Fixed overlay bug
1c108c9 
Signed-off-by: rapterjet2004 <[email protected]>
@mahibi mahibi force-pushed the issue-4498-voice-recording-icon-overlay-bug branch from a66d0cf to 1c108c9 Compare December 10, 2024 09:06
@mahibi mahibi enabled auto-merge December 10, 2024 09:06
@mahibi mahibi added this to the 21.0.0 milestone Dec 10, 2024
@mahibi
Copy link
Collaborator

mahibi commented Dec 10, 2024

/backport to stable-20.1

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings158158
Errors7272

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4525-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit aa43824 into master Dec 10, 2024
18 checks passed
@mahibi mahibi deleted the issue-4498-voice-recording-icon-overlay-bug branch December 10, 2024 09:33
@backportbot backportbot bot mentioned this pull request Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.

message drafts -> send and voice recording icon overlay
2 participants
@rapterjet2004 @mahibi