Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat scrolls to the top when returning from information #826

Closed
nickvergessen opened this issue May 8, 2020 · 2 comments · Fixed by #895
Closed

Chat scrolls to the top when returning from information #826

nickvergessen opened this issue May 8, 2020 · 2 comments · Fixed by #895
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) bug Something isn't working high High priority regression Regression of a previous working feature

Comments

@nickvergessen
Copy link
Member

  1. Enter a conversation
  2. Go to "Conversation information"
  3. Go back
  4. See chat scrolls all to the top.
@nickvergessen nickvergessen added bug Something isn't working 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) labels May 8, 2020
@jancborchardt jancborchardt added the regression Regression of a previous working feature label May 12, 2020
@mario mario mentioned this issue May 21, 2020
Closed
@nickvergessen nickvergessen added the medium Medium priority label Jun 12, 2020
@jancborchardt jancborchardt added high High priority and removed medium Medium priority labels Jun 12, 2020
@ctilluma
Copy link

ctilluma commented Aug 9, 2020

Might want to move this back to high. I was reproducing the issue, and the third time got an app crash.

I think all we need to do is maintain the state of where we are in the conversation, so when it calls the instance state on drawing the information activity, we can adjust the view model to hold the current activity state.

@ctilluma
Copy link

This is tied to #880 as we need to hold where we are in the view as well as any unfinished tasks in instancestate.

@dan0xii dan0xii mentioned this issue Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) bug Something isn't working high High priority regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ChatView scrolling fix dan0xii/talk-android
3 participants
@nickvergessen @jancborchardt @ctilluma