Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(talk_app): Implement swipe-to-reply #2612

Merged
merged 2 commits into from
Dec 8, 2024
Merged

feat(talk_app): Implement swipe-to-reply #2612

merged 2 commits into from
Dec 8, 2024

Conversation

provokateurin
Copy link
Member

Closes #2495

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.89%. Comparing base (c1e5c9c) to head (1e4928e).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ework/packages/talk_app/lib/src/utils/helpers.dart 85.71% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2612      +/-   ##
==========================================
- Coverage   28.90%   28.89%   -0.01%     
==========================================
  Files         372      373       +1     
  Lines      136622   136630       +8     
==========================================
- Hits        39490    39481       -9     
- Misses      97132    97149      +17
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from 0a3aa4c
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø) Carriedforward from 0a3aa4c
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from 0a3aa4c
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 0a3aa4c
interceptor_http_client 97.18% <ø> (ø) Carriedforward from 0a3aa4c
neon_dashboard 96.05% <ø> (ø) Carriedforward from 0a3aa4c
neon_framework 59.25% <ø> (-2.19%) ⬇️
neon_http_client 93.61% <ø> (-0.71%) ⬇️ Carriedforward from 0a3aa4c
neon_notifications 100.00% <ø> (ø) Carriedforward from 0a3aa4c
neon_rich_text 100.00% <ø> (?)
neon_storage 94.66% <ø> (ø) Carriedforward from 0a3aa4c
neon_talk 99.45% <ø> (ø) Carriedforward from 0a3aa4c
nextcloud 24.33% <ø> (ø) Carriedforward from 0a3aa4c
notifications_app 97.43% <ø> (ø)
notifications_push_repository 98.11% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 0a3aa4c
talk_app 98.82% <91.66%> (-0.19%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ramework/packages/talk_app/lib/src/pages/room.dart 100.00% <100.00%> (ø)
...ork/packages/talk_app/lib/src/widgets/message.dart 98.76% <100.00%> (-0.04%) ⬇️
...k/packages/talk_app/lib/src/widgets/reactions.dart 100.00% <100.00%> (ø)
...ework/packages/talk_app/lib/src/utils/helpers.dart 91.30% <85.71%> (-8.70%) ⬇️

... and 4 files with indirect coverage changes

@provokateurin provokateurin force-pushed the feat/talk_app/swipe-to-reply branch from 2252a74 to 1e4928e Compare December 8, 2024 12:00
@provokateurin provokateurin merged commit 5cceeea into main Dec 8, 2024
11 checks passed
@provokateurin provokateurin deleted the feat/talk_app/swipe-to-reply branch December 8, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leptopoda Leptopoda Leptopoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement swipe-to-reply
2 participants
@provokateurin @Leptopoda