Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote "Unknown instruction format" warning to an error #31

Open
neobrain opened this issue Aug 18, 2015 · 1 comment
Open

Promote "Unknown instruction format" warning to an error #31

neobrain opened this issue Aug 18, 2015 · 1 comment

Comments

@neobrain
Copy link
Owner

e.g. a like like ; invalid-comment will trigger the warning source/vshader.vsh:15: warning: Unknown instruction format, treating like EOF: " and then abort parsing. Instead, this should be considered an error.

@machinamentum
Copy link
Contributor

This change seems simple (std::cerr output -> throw), but could you elaborate on the behavior caused by Windows EOF? I don't have a Windows machine, so I can't extensively explore this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants